Creating OPENFILENAME struct for GetOpen/SaveFileName

zenzag · October 25, 2016, 2:26am

Hi there.

I/we are wanting to use the Windows API GetOpenFilename/GetSaveFileName functions. I have been trying to construct a GROUP (or CLASS) based on the OPENFILENAME struct but can’t seem to get it right.

My call to GetOpenFileName(OPENFILENAME) seems to work OK in that I don’t get a GPF, but it doesn’t open a window (returns 0) and the Windows extended error is 1 (CDERR_STRUCTSIZE), the lStructSize member … is invalid.

Now. Many, many years ago, Mark Goldberg alluded to a solution in this post: http://computer-programming-forum.com/18-clarion/fb1bb69dc5bcda5d.htm but no code was posted.

Mark, I managed to track you down (provided you are the same Mark Goldberg). Do you have a solution you can share with me?

Days of searching for Clarion example code has confused me more than ever.

Some indicate the prototype should be:
GetSaveFileName(*OPENFILENAME)BOOL,PASCAL,RAW,NAME(‘GetSaveFileNameA’)
others show it as:
GetSaveFileName(LONG)BOOL,PASCAL,RAW,NAME(‘GetSaveFileNameA’)

Anybody else able to assist?

Many, many thanks.

Andrew.

Mathew · October 25, 2016, 9:55am

Hi Andrew,
You may have a very good reason that you want to use GetOpenFilename API. But, why not use clarion’s FILEDIALOGA function instead?

Just curious

zenzag · October 25, 2016, 9:35pm

G’day Mathew.

FileDialog is fine if you want to Open a file. A user selects a name etc and the full filename is returned, drive:\path\filename.ext

On the other hand, if you want to save a file and the user changes the name, regardless of the file extension selected for the filter/droplist, if the user does not include an extension, it is not added to the filename.

The link included in my OP outlines the issue. Mark Goldberg encountered the same and developed a function to call the Windows API GetSaveFileName which contains considerably more information about the whole file save process (including the selected extension).

I am having a little trouble getting my head around replicating the struct (including pointers) etc in Clarion. Most other API or external DLL calls I have no trouble with.

Cheers.

< edit > Mathew, just noticed you said FILEDIALOGA. As below, still using C5, no FILEIDALOGA < /edit >

Rick_UpperPark · October 25, 2016, 10:19pm

A new attribute was added a number of years ago to the Clarion FileDialog ( I believe in one of the C6 updates).
File:AddExtension. This adds the extension to the file name in the save dialog if none was included.
Take a look and see if that helps.

Rick

zenzag · October 26, 2016, 12:28am

Thanks Rick.

I’m sure it would but for various reasons, still using C5Pro, so still stuck with same issue.

MarkGoldberg · October 28, 2016, 11:26am

Hi Andrew,

I’ll see if I can dig up the code in question.

lchudakov · October 30, 2016, 5:54pm

Hi Andrew,

How is the structure prototyped?
If LONG is used then you pass address of the structure

Leonid

zenzag · November 2, 2016, 2:00am

Hi Mark and Leonid (and others),
While looking for something else marginally related, I came across this site: http://www.authord.com/products/Clarion/ , and part of the way down is a WinAPI toolkit. Lo and behold, there was an example of GetOpen/SaveFileName, albeit as a template and for an older version, but it pointed out a couple of things I was doing wrong (eg getting the SIZE of the wrong object).
Many thanks to that developer, but I am now well on my way to resolving my issue.
Thanks everyone for your help.

Mark, I would be curious to see your code if available.

Cheers.

MarkGoldberg · November 3, 2016, 12:07pm

@zenzag

Please read the Readme.MD in the gist where I discuss some short comings of the posted code.

gist.github.com

https://gist.github.com/MarkGoldberg/af20b9a8797184517ff1f11e92eb9f89

API_CommonDialog.inc

                      compile('***',_WIDTH32_)
ANSI    EQUATE('A')
                      ***
                      omit   ('***',_WIDTH32_)
ANSI    EQUATE('')
                      ***



!-Rely On Once due to IDE Navigation Bugs-!     omit('*** ifdef API_CommonDialog ***',ifDef_API_CommonDialog)

This file has been truncated. show original

FileSaveName.clw

  MEMBER('b4')
  INCLUDE('API_CommonDialog.inc'),ONCE !has map
  !INCLUDE('FileSaveName.inc'),ONCE


MySaveFileName  PROCEDURE(STRING xTitle, *STRING xInOutDriveDir  ,*STRING xInOutFileName, STRING xExtensions)!,bool,proc
HoldPath        STRING(FILE:MaxFilePath),AUTO
RetFilePicked   BOOL,AUTO
   CODE
   HoldPath = LONGPATH()

This file has been truncated. show original

ReadMe.MD


Pardon the messy code, 
I have not cleaned this at all as it seemed to me that if you encounter problems that some of my ancient notes etc. might be handy

Example call:
  if MySaveFileName('Save Image As...', rou:sFileName_DriveDir, rou:sFileName_BaseName,'PNG-portable network graphics (recommended)|*.PNG|Bitmap|*.BMP|JPEG|*.JPG|TIFF|*.TIF|Encapsulated Post Script|*.EPS|RGB|*.RBG') 
 
 
Note about FileSaveName.CLW 
-  I notice it has a MEMBER statement

This file has been truncated. show original

There are more than three files. show original

zenzag · November 3, 2016, 10:16pm

Wow! Thanks very much for that.

My implementation is somewhat ‘thinner’ than yours, but it does what I require for now.

Do you mind if I borrow some of your ideas (and code) so as to improve my own?

I will have to invest some time to understanding WINAPI a bit more.

Cheers.

MarkGoldberg · November 4, 2016, 11:59am

Please do improve it.
I’d love to see the result.
I suppose I should’ve added a LGPLv3 (http://www.gnu.org/licenses/lgpl.html) to it.

totalhip · November 4, 2016, 2:27pm

I apologize for a bit of a sidetrack, but after repeatedly reading the docs just yesterday, I still miss the difference between FILEDIALOG and FILEDIALOGA. Might anyone have some insight?

Thank you,
Douglas

Mathew · November 4, 2016, 5:17pm

FILEDIALOGA in the help is title as (extended file dialog)

This has an extra parameter (index) as shown below:
FILEDIALOGA( [title] ,file [,extensions] [,flag] [,index] )

index = A signed integer variable used to select a different default extension by specifying the index number.

Example Code:

Fxt SIGNED(2)

FILEDIALOGA(‘Choose File to View’ ,FileName, ‘Text|.TXT|Source|.CLW’, FILE:LongName, Fxt)

If Fxt is 1, it would default the file extension to “Text” when the file dialog is opened. If set to 2, it would default the file extension to “Source”.

Fxt=1

Fxt=2

totalhip · November 4, 2016, 5:43pm

Mathew,
Thank you. Definitely one of those things where it now seems so obvious. I kept looking at the docs regarding “extensions” and did not even notice the index parameter difference.